Re: [PATCH] Fix ouside scope t_ctid (ItemPointerData)

Em qui., 14 de mai. de 2020 às 15:07, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> escreveu:

> Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> writes:
> > The patch is primarily intended to correct the use of ItemPointerData.
>
> What do you think is being "corrected" here? It looks to me like
> just some random code rearrangements that aren't even clearly
> bug-free, let alone being stylistic improvements.
>
It is certainly working, but trusting that the memory of a local variable
will not change,
when it loses its scope, is a risk that, certainly, can cause bugs,
elsewhere.
And it is certainly very difficult to discover its primary cause.

regards,
Ranier Vilela