Re: Avoid mix char with bool type in comparisons

Em qui., 6 de out. de 2022 às 20:52, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> escreveu:

> Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> writes:
> > So, any use of this GinTernaryValue are:
>
> > 1. if (key->entryRes[j]) be FALSE if GIN_FALSE
> > 2. if (key->entryRes[j]) be TRUE if GIN_TRUE
> > 3. if (key->entryRes[j]) be TRUE if GIN_MAYBE
>
> Yeah, that's how it's designed. Unless you can point to a bug,
> I do not think we ought to change this code.
>
Thanks for answering.

My main concerns is this point:
/* If already matched on earlier page, do no extra work */
- if (key->entryRes[j])
+ if (key->entryRes[j] == GIN_TRUE)
continue;

If GIN_MAYBE cases are erroneously ignored.

regards,
Ranier Vilela