| From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
|---|---|
| To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Signed vs. Unsigned (some) |
| Date: | 2021-06-12 02:05:29 |
| Message-ID: | CAEudQAp=ZwKjrP4L+CzqV7SmWiaQidPPRqj4tqdjDG4KBx5yrg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Removing legitimate warnings can it be worth it?
-1 CAST can be wrong, when there is an invalid value defined
(InvalidBucket, InvalidBlockNumber).
I think depending on the compiler -1 CAST may be different from
InvalidBucket or InvalidBlockNumber.
pg_rewind is one special case.
All cases of XLogSegNo (uint64) initialization are zero, but in pg_rewind
was used -1?
I did not find it InvalidXLogSegNo!
Not tested.
Trivial patch attached.
best regards,
Ranier Vilela
| Attachment | Content-Type | Size |
|---|---|---|
| fix_signed_vs_unsigned.patch | application/octet-stream | 3.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2021-06-12 02:33:25 | pg_filenode_relation(0,0) elog |
| Previous Message | Justin Pryzby | 2021-06-12 01:54:08 | Re: A new function to wait for the backend exit after termination |