Re: [PATCH] Fix division by zero (explain.c)

Em sáb., 9 de mai. de 2020 às 01:45, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> escreveu:

> James Coleman <jtc331(at)gmail(dot)com> writes:
> > There are always full sort groups before any prefix groups can happen,
> > so we know (even though the tooling doesn't) that the 2nd test can
> > never contradict the first.
>
> So maybe an assertion enforcing that would be appropriate?
> Untested, but:
>
> - if (fullsortGroupInfo->groupCount == 0 &&
> - prefixsortGroupInfo->groupCount == 0)
> + if (fullsortGroupInfo->groupCount == 0)
> + {
> + Assert(prefixsortGroupInfo->groupCount ==
> 0);
> continue;
> + }
>
I agree, asserts always help.

regards,
Ranier Vilela