Re: Improve list manipulation in several places

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Richard Guo <guofenglinux(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Improve list manipulation in several places
Date: 2023-04-21 16:11:56
Message-ID: CAEudQAowjQEWP80yxo4UBJV1Egkj76HKP-8FbHRpJwiJBV=CFQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Em sex, 21 de abr de 2023 9:10 AM, David Rowley <dgrowleyml(at)gmail(dot)com>
escreveu:

> On Fri, 21 Apr 2023 at 23:16, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
> > Perhaps list_delete_nth_cell needs to check NIL too?
> > + if (list == NIL)
> > + return NIL;
>
> Which cell would you be deleting from an empty list?
>
None.
But list_delete_nth_cel can checks a length of NIL list.

Perhaps a assert?

regards,
Ranier Vilela

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Steinar Kaldager 2023-04-21 16:13:33 Improving worst-case merge join performance with often-null foreign key
Previous Message Tom Lane 2023-04-21 15:48:51 Re: Order changes in PG16 since ICU introduction