Use array as object (src/fe_utils/parallel_slot.c)

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Use array as object (src/fe_utils/parallel_slot.c)
Date: 2022-08-11 12:52:49
Message-ID: CAEudQAokk1h_pUwGXsYS4oVOuf35s1O2o3TXGHpV8=AWikvgHA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

One other case suspicious, which I think deserves a conference.
At function wait_on_slots (src/fe_utils/parallel_slot.c)
The variable "slots" are array, but at function call SetCancelConn,
"slots" are used as an object, which at the very least would be suspicious.

cancelconn wouldn't that be the correct argument?

regards,
Ranier Vilela

Attachment Content-Type Size
001-fix-cancel-conn.patch application/octet-stream 409 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Euler Taveira 2022-08-11 13:26:40 Re: Allow logical replication to copy tables in binary format
Previous Message Julien Rouhaud 2022-08-11 12:23:03 Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c)