re: postgres_fdw hint messages

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Subject: re: postgres_fdw hint messages
Date: 2022-08-25 17:31:41
Message-ID: CAEudQAoifBDepk=ZK7nO_-Rh5dT-r5OTaY43jkzZgnfR0w2W7g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>The postgres_fdw tests contain this (as amended by patch 0001):

>ALTER SERVER loopback_nopw OPTIONS (ADD password 'dummypw');
>ERROR: invalid option "password"
>HINT: Valid options in this context are: service, passfile,
>channel_binding, connect_timeout, dbname, host, hostaddr, port, options,
>application_name, keepalives, keepalives_idle, keepalives_interval,
>keepalives_count, tcp_user_timeout, sslmode, sslcompression, sslcert,
>sslkey, sslrootcert, sslcrl, sslcrldir, sslsni, requirepeer,
>ssl_min_protocol_version, ssl_max_protocol_version, gssencmode,
>krbsrvname, gsslib, target_session_attrs, use_remote_estimate,
>fdw_startup_cost, fdw_tuple_cost, extensions, updatable, truncatable,
>fetch_size, batch_size, async_capable, parallel_commit, keep_connections

>This annoys developers who are working on libpq connection options,
>because any option added, removed, or changed causes this test to need
>to be updated.

>It's also questionable how useful this hint is in its current form,
>considering how long it is and that the options are in an
>implementation-dependent order.

>Possible changes:

>- Hide the hint from this particular test (done in the attached patches).
+1
I vote for this option.
Less work for future developers changes, I think worth the effort.

Anyway, in alphabetical order, it's a lot easier for users to read.

Patch attached.

regards,
Ranier Vilela

Attachment Content-Type Size
0003-reorder-alphabetical-libpq-options.patch application/octet-stream 15.6 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2022-08-25 17:40:57 Re: Schema variables - new implementation for Postgres 15
Previous Message Robert Haas 2022-08-25 16:12:46 has_privs_of_role vs. is_member_of_role, redux