Re: PG compilation error with Visual Studio 2015/2017/2019

Em dom., 19 de abr. de 2020 às 12:34, Juan José Santamaría Flecha <
juanjo(dot)santamaria(at)gmail(dot)com> escreveu:

>
> On Sun, Apr 19, 2020 at 1:58 PM Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
>
>> Em dom., 19 de abr. de 2020 às 07:16, Juan José Santamaría Flecha <
>> juanjo(dot)santamaria(at)gmail(dot)com> escreveu:
>>
>>> On Sat, Apr 18, 2020 at 1:43 PM Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
>>> wrote:
>>>
>>>> I have some observations about this patch, related to style, if you
>>>> will allow me.
>>>>
>>> Please find attached a revised version.
>>>
>> Looks good to me, but, sorry, I think I missed a glitch in the previous
>> review.
>> If _create_locale fail, no need to call _free_locale(loct);.
>>
>> Another point is, what is the difference between pg_mbstrlen and wcslen?
>> It would not be better to use only wcslen?
>>
>
> pg_mbstrlen() is for multibyte strings and wcslen() is for wide-character
> strings, the "pg" equivalent would be pg_wchar_strlen().
>
> Attached have the patch with this comments.
>>
>
> + } else
>
> This line needs a break, other than that LGTM.
>
Sure. Attached new patch with this revision.

regards,
Ranier Vilela