From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
---|---|
To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Cc: | davinder singh <davindersingh2692(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Subject: | PG compilation error with Visual Studio 2015/2017/2019 |
Date: | 2020-04-14 15:41:44 |
Message-ID: | CAEudQAo4J+fOnAciW4Ja+k5wEk0o7490w-5T-+ysrmpC+uhjww@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>>I m still working on testing this patch. If anyone has Idea please
suggest.
I still see problems with this patch.
1. Variable loct have redundant initialization, it would be enough to
declare so: _locale_t loct;
2. Style white space in variable rc declaration.
3. Style variable cp_index can be reduced.
if (tmp != NULL) {
size_t cp_index;
cp_index = (size_t)(tmp - winlocname);
strncpy(loc_name, winlocname, cp_index);
loc_name[cp_index] = '\0';
4. Memory leak if _WIN32_WINNT >= 0x0600 is true, _free_locale(loct); is
not called.
5. Why call _create_locale if _WIN32_WINNT >= 0x0600 is true and loct is
not used?
regards,
Ranier Vilela
From | Date | Subject | |
---|---|---|---|
Next Message | Erik Rijkers | 2020-04-14 15:44:26 | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions |
Previous Message | Tom Lane | 2020-04-14 15:41:23 | Re: Properly mark NULL returns in numeric aggregates |