From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
---|---|
To: | Oskari Saarenmaa <os(at)ohmu(dot)fi> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tobias Oberstein <tobias(dot)oberstein(at)gmail(dot)com> |
Subject: | Re: pread() and pwrite() |
Date: | 2018-07-27 02:04:05 |
Message-ID: | CAEepm=2qRXWM+uX26dPn6S=TAqi8FfuAZ9vG8tZW9Jo7w6YeQw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Jul 20, 2018 at 8:14 PM, Oskari Saarenmaa <os(at)ohmu(dot)fi> wrote:
> On Thu, Jul 12, 2018 at 01:55:31PM +1200, Thomas Munro wrote:
>> [...] I'm not even sure I'd bother adding "At" to the
>> function names. If there are any extensions that want the old
>> interface they will fail to compile either way. Note that the BufFile
>> interface remains the same, so hopefully that covers many use cases.
>
> IIRC I used the "At" suffixes in my first version of the patch before
> completely removing the functions which didn't take an offset argument
> Now that they're gone I agree that we could just drop the "At" suffix;
> "at" suffix is also used by various POSIX functions to operate in a
> specific directory which may just add to confusion.
Done. Rebased.
--
Thomas Munro
http://www.enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
0001-Use-pread-pwrite-instead-of-lseek-read-write-v3.patch | application/octet-stream | 25.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2018-07-27 02:26:55 | Re: Making "COPY partitioned_table FROM" faster |
Previous Message | Andres Freund | 2018-07-27 01:53:06 | Deprecating, and scheduling removal of, pg_dump's tar format. |