Re: [COMMITTERS] pgsql: Rearm statement_timeout after each executed query.

From: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Rearm statement_timeout after each executed query.
Date: 2018-02-08 00:04:13
Message-ID: CAEepm=3BdR_yB_WEkKGF0M180f6=f=4R4R6o6mWJL9e8vtj6wg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Feb 6, 2018 at 5:21 PM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 9/18/17 22:41, Andres Freund wrote:
>> Rearm statement_timeout after each executed query.
>
> This appears to have broken statement_timeout behavior in master such
> that only every second query is affected by it.

Yeah, I also just ran into this while testing a nearby complaint about
statement timeouts vs parallel query. In the error path
stmt_timeout_active remains true, so the next statement does nothing
in enable_statement_timeout(). I think we just need to clear that
flag in the error path, right where we call disable_all_timeouts().
See attached.

--
Thomas Munro
http://www.enterprisedb.com

Attachment Content-Type Size
fix-statement-timeout.patch application/octet-stream 501 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2018-02-08 01:39:32 pgsql: postgres_fdw: Remove CTID output from some tests.
Previous Message Robert Haas 2018-02-07 20:39:31 pgsql: postgres_fdw: Push down UPDATE/DELETE joins to remote servers.

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2018-02-08 00:21:15 Re: PDF Builds on borka (Debian/stretch) broken - 9.6
Previous Message Alvaro Herrera 2018-02-07 23:52:26 Re: [HACKERS] Vacuum: allow usage of more than 1GB of work mem