| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: POC: Sharing record typmods between backends |
| Date: | 2017-08-23 12:04:42 |
| Message-ID: | CAEepm=37RvJC3U1v5S6Pj+Xb2sE5DxL_+YSvoHzgP1btC8Hs5w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Aug 23, 2017 at 11:58 PM, Thomas Munro
<thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> On Wed, Aug 23, 2017 at 5:46 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> - Afaict GetSessionDsmHandle() uses the current rather than
>> TopMemoryContext. Try running the regression tests under
>> force_parallel_mode - crashes immediately for me without fixing that.
>
> Gah, right. Fixed.
That version missed an early return case where dsm_create failed.
Here's a version that restores the caller's memory context in that
case too.
--
Thomas Munro
http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| shared-record-typmods-v8.patchset.tgz | application/x-gzip | 23.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2017-08-23 12:55:09 | Re: proposal: psql command \graw |
| Previous Message | Thomas Munro | 2017-08-23 11:58:04 | Re: POC: Sharing record typmods between backends |