From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
---|---|
To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
Cc: | Thomas Munro <tmunro(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Use pg_pread() and pg_pwrite() for data files and WAL. |
Date: | 2018-11-06 22:43:07 |
Message-ID: | CAEepm=2y_kbutszO_T2WRr5KnURiSQZCGDTA-byRHMcsa-sXFw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On Wed, Nov 7, 2018 at 11:32 AM Andrew Dunstan
<andrew(dot)dunstan(at)2ndquadrant(dot)com> wrote:
> On 11/6/18 4:01 PM, Thomas Munro wrote:
> > Use pg_pread() and pg_pwrite() for data files and WAL.
> >
> > Cut down on system calls by doing random I/O using offset-based OS
> > routines where available. Remove the code for tracking the 'virtual'
> > seek position. The only reason left to call FileSeek() was to get
> > the file's size, so provide a new function FileSize() instead.
>
> Getting this warning (gcc 8.2.1 Fedora 29):
>
> Nov 06 17:18:55
> /home/bf/bfr/root/HEAD/pgsql.build/../pgsql/src/backend/storage/file/fd.c:
> In function ‘FileSize’:
> Nov 06 17:18:55
> /home/bf/bfr/root/HEAD/pgsql.build/../pgsql/src/backend/storage/file/fd.c:2007:11:
> warning: variable ‘vfdP’ set but not used [-Wunused-but-set-variable]
> Nov 06 17:18:55 Vfd *vfdP;
> Nov 06 17:18:55 ^~~~
Thanks, will fix.
--
Thomas Munro
http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2018-11-06 23:09:46 | pgsql: Remove set-but-unused variable. |
Previous Message | Andrew Dunstan | 2018-11-06 22:32:21 | Re: pgsql: Use pg_pread() and pg_pwrite() for data files and WAL. |