| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Add support for coordinating record typmods among parallel worke |
| Date: | 2017-09-15 04:42:50 |
| Message-ID: | CAEepm=2q2OoJ5K1Mg2_XaqjSSRbMTAmE4V7fsM5O3yTWWkb2aw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Sep 15, 2017 at 4:34 PM, Thomas Munro
<thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> Here's a version that just forward declares SharedRecordTypmodRegistry
> in session.h (but keeps the typedef in typcache.h where it is useful
> for shorter function prototypes). Neither GCC 6 -Wall -std=c89 not
> Clang -Wall -std=c89 complained about this problem. I found an old
> GCC 4.3 compiler and it complained about the typedef redefinition and
> also the use of an anonymous union, also fixed in the attached. Sorry
> about that -- clearly I need to test my patches on more compilers in
> future.
Rebased on your fix. Investigating the runtime failure...
--
Thomas Munro
http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Don-t-use-anonymous-unions.patch | application/octet-stream | 3.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-09-15 04:53:11 | Re: pgsql: Add support for coordinating record typmods among parallel worke |
| Previous Message | Thomas Munro | 2017-09-15 04:34:10 | Re: pgsql: Add support for coordinating record typmods among parallel worke |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2017-09-15 04:43:08 | Re: path toward faster partition pruning |
| Previous Message | Thomas Munro | 2017-09-15 04:34:10 | Re: pgsql: Add support for coordinating record typmods among parallel worke |