| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Loaded footgun open_datasync on Windows |
| Date: | 2018-06-06 04:52:46 |
| Message-ID: | CAEepm=2S-25uSXhhtPWrS0gm0S8r_Q7brD+Ab-0ah=+bYbmbYw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 6, 2018 at 4:48 PM, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Wed, Jun 06, 2018 at 09:58:34AM +0530, Amit Kapila wrote:
>> I think we need to explore a bit, if we want to remove that, for example
>> some of the frontend modules (like pg_receivewal, pg_recvlogical) call two
>> argument open which would require change.
>
> Yeah, sure. I am not saying that this is straight-forward, but it may
> be worth the switch in the long term. What I am sure about is that the
> proposed patch is simple, but that does not look like a correct
> approach to me as other tools may benefit from it.
Like this other unresolved problem:
https://www.postgresql.org/message-id/flat/16922.1520722108%40sss.pgh.pa.us
--
Thomas Munro
http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-06-06 05:01:49 | Re: Why is fncollation in FunctionCallInfoData rather than fmgr_info? |
| Previous Message | Michael Paquier | 2018-06-06 04:48:47 | Re: Loaded footgun open_datasync on Windows |