| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: pg_recvlogical.c doesn't build with --disable-integer-datetimes |
| Date: | 2017-02-17 20:05:54 |
| Message-ID: | CAEepm=1wVjmuPCdtgyn7-huNFAabhu4b7VwoRpCcVtQ7C=ScTw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Feb 18, 2017 at 9:04 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
>> On February 17, 2017 11:40:57 AM PST, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> AFAICS, if you want to build with -Werror, you have to configure
>>> without that and then inject it afterwards. I wonder how people who
>>> use -Werror are handling that. Is it possible to do at all in a
>>> buildfarm critter?
>
>> Yea, I complained about that before. I think we'd have to add an extra configure option for it, because we rely in setting it only for certain tests. Personally I use CEXTRA (IIRC) to achieve that result after configure ran.
>
> [ pokes around... ] Ah, that's called COPT, and it's entirely
> undocumented :-(. Probably ought to fix that.
One way to set that up is like this:
$ cat src/Makefile.custom
COPT=-Wall -Werror $(CC_OPT)
--
Thomas Munro
http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-02-17 20:21:05 | Re: pg_recvlogical.c doesn't build with --disable-integer-datetimes |
| Previous Message | Tom Lane | 2017-02-17 20:04:09 | Re: pg_recvlogical.c doesn't build with --disable-integer-datetimes |