| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Thomas Munro <tmunro(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fix handling of HBA ldapserver with multiple hostnames. |
| Date: | 2018-11-13 05:44:35 |
| Message-ID: | CAEepm=1EW00VuUQw5Xkz6i3Dd-DfD5ngbFVSw9a-0zkODb-EmA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Tue, Nov 13, 2018 at 6:37 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Thomas Munro <tmunro(at)postgresql(dot)org> writes:
> > Fix handling of HBA ldapserver with multiple hostnames.
>
> longfin thinks this has a problem with const-ness:
>
> auth.c:2380:10: error: passing 'const char *' to parameter of type 'void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
> pfree(hostname);
> ^~~~~~~~
Thanks, fixing. Embarassingly, I had turned off -Werror for this
because my Mac spews strange warnings when you use OpenLDAP, a problem
to which there must be a better solution.
--
Thomas Munro
http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-11-13 05:54:37 | Re: pgsql: Fix handling of HBA ldapserver with multiple hostnames. |
| Previous Message | Amit Kapila | 2018-11-13 05:40:55 | pgsql: Fix the initialization of atomic variable introduced by the |