| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11) |
| Date: | 2018-09-17 00:04:34 |
| Message-ID: | CAEepm=1+OWGUOMOaJU+HmTqPXk3NS8QT1SfhBHn4hFHt=0p7Mg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 10, 2018 at 6:26 AM Andrew Dunstan
<andrew(dot)dunstan(at)2ndquadrant(dot)com> wrote:
> On 01/24/2018 04:30 AM, Pavel Stehule wrote:
> >
> > I am sending updated version.
> >
> > Very much thanks for very precious review
>
> Thomas,
>
> I am unable to replicate the Linux failure seen in the cfbot on my
> Fedora machine. Both when building with libxml2 and without, after
> applying the latest patch the tests pass without error. Can you please
> investigate what's going on here?
Well this is strange... I can't reproduce the problem either with or
without --with-libxml on a Debian box (was trying to get fairly close
to the OS that Travis runs on). But I see the same failure when I
apply the patch on my FreeBSD 12 laptop and test without
--with-libxml. Note that when cfbot runs it, the patch is applied
with FreeBSD patch, and then it's tested without --with-libxml on
Ubuntu (Travis's default OS). [Side note: I should change it to build
--with-libxml, but that's not the point.] So the common factor is a
different patch implementation. I wonder if a hunk is being
misinterpreted.
--
Thomas Munro
http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matheus de Oliveira | 2018-09-17 03:03:17 | Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT |
| Previous Message | Tom Lane | 2018-09-16 23:03:12 | More deficiencies in outfuncs/readfuncs processing |