A couple of postgresql.conf.sample discrepancies

From: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: A couple of postgresql.conf.sample discrepancies
Date: 2017-07-27 04:27:09
Message-ID: CAEepm=0B7yM9MZSviq1d-hnt4KoaRVeJvSfAyVfykNV-pVDqug@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi hackers,

Here's a script that reminds you about GUCs you forgot to put in
postgresql.conf.sample. It probably needs some work. Does this
already happen somewhere else? I guess not, because it found two
discrepancies:

$ ./src/tools/check_sample_config.pl
enable_gathermerge appears in guc.c but not in postgresql.conf.sample
trace_recovery_messages appears in guc.c but not in postgresql.conf.sample

I think the first should be listed in postgresql.conf.sample, but the
second should probably be flagged as GUC_NOT_IN_SAMPLE. See attached.

--
Thomas Munro
http://www.enterprisedb.com

Attachment Content-Type Size
fix-sample-config.patch application/octet-stream 1.0 KB
check-sample-config-v1.patch application/octet-stream 2.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2017-07-27 05:20:45 Re: Log LDAP "diagnostic messages"?
Previous Message Masahiko Sawada 2017-07-27 03:58:00 Re: Transactions involving multiple postgres foreign servers