| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Petr Korobeinikov <pkorobeinikov(at)gmail(dot)com>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, Jeevan Chalke <jeevan(dot)chalke(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: psql :: support for \ev viewname and \sv viewname |
| Date: | 2016-05-02 12:53:00 |
| Message-ID: | CAEZATCXuCBDoYoP2y+AgyMnK_nV-YVF_MY+8GF=JivjJzLN2zQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 27 April 2016 at 08:36, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
> Here is a rough patch based on the way pg_dump handles this. It still
> needs a bit of polishing -- in particular I think fmtReloptionsArray()
> (copied from pg_dump) should probably be moved to string_utils.c so
> that it can be shared between pg_dump and psql. Also, I'm not sure
> that's the best name for it -- I think appendReloptionsArray() is a
> more accurate description of what is does.
>
Here are updated patches doing that --- the first moves
fmtReloptionsArray() from pg_dump.c to fe_utils/string_utils.c so that
it can be shared by pg_dump and psql, and renames it to
appendReloptionsArray(). The second patch fixes the actual psql bug.
Regards,
Dean
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Move-and-rename-fmtReloptionsArray.patch | text/x-patch | 8.5 KB |
| 0002-Make-psql-s-ev-and-sv-commands-handle-view-reloption.patch | text/x-patch | 4.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-05-02 12:53:21 | Re: WIP: Covering + unique indexes. |
| Previous Message | Robert Haas | 2016-05-02 12:50:05 | Re: pg_dump dump catalog ACLs |