Re: [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

From: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Thom Brown <thom(at)linux(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jim Nasby <jim(at)nasby(dot)net>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID
Date: 2011-11-25 16:16:29
Message-ID: CAEZATCXRAVDat1-0pVDcr=9tx55LZMm5zsLZt=BcKX85J=90eg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 24 November 2011 21:50, Alvaro Herrera <alvherre(at)commandprompt(dot)com> wrote:
>
> Excerpts from Alvaro Herrera's message of vie nov 11 00:32:33 -0300 2011:
>> Excerpts from Thom Brown's message of jue nov 10 21:28:06 -0300 2011:
>> >
>> > On 10 November 2011 23:56, Thom Brown <thom(at)linux(dot)com> wrote:
>>
>> > > The dump correctly contains:
>> > >
>> > > CREATE TABLE a (
>> > >    num integer,
>> > >    CONSTRAINT meow CHECK ((num < 20)) NOT VALID
>> > > );
>> >
>> > Actually I mean incorrectly contains, because the constraint needs
>> > adding after the data insertion, not as part of the create table
>> > statement.
>>
>> Interesting, thanks -- I'll look into it.
>
> I have just pushed a fix for this.  Thanks for the report and sorry for
> the delay.
>

There is a similar problem with NOT VALID check constraints on
domains. These are still being dumped as part of the CREATE DOMAIN
statement, which is invalid syntax, so they need to be dumped
separately from the domain creation, and presumably also after any
data for tables that use them.

Regards,
Dean

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Dean Rasheed 2011-11-25 16:45:34 Re: [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID
Previous Message Robert Haas 2011-11-25 13:19:14 pgsql: Move "hot" members of PGPROC into a separate PGXACT array.

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2011-11-25 16:39:31 Re: Displaying accumulated autovacuum cost
Previous Message Robert Haas 2011-11-25 13:31:55 Re: proposal: use errcontext for custom exception too