| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Vik Fearing <vik(at)postgresfriends(dot)org>, Isaac Morland <isaac(dot)morland(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: MERGE ... RETURNING |
| Date: | 2023-02-07 10:56:52 |
| Message-ID: | CAEZATCWX7oXv=LKK=wde4UTduS1Qow0myUAKeEAoiw9nUoj_Kg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 23 Jan 2023 at 16:54, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
>
> On Sun, 22 Jan 2023 at 19:08, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> >
> > Regarding mas_action_idx, I would have thought that it belongs in
> > MergeAction rather than MergeActionState. After all, you determine it
> > once at parse time, and it is a constant from there onwards, right?
>
> Oh, yes that makes sense (and removes the need for a couple of the
> executor changes). Thanks for looking.
>
Attached is a more complete patch, with that change and more doc and
test updates.
A couple of latest changes from this patch look like they represent
pre-existing issues with MERGE that should really be extracted from
this patch and applied to HEAD+v15. I'll take a closer look at that,
and start new threads for those.
Regards,
Dean
| Attachment | Content-Type | Size |
|---|---|---|
| support-merge-returning-v3.patch | text/x-patch | 85.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rinat Shigapov | 2023-02-07 11:08:26 | Re: Too coarse predicate locks granularity for B+ tree indexes |
| Previous Message | Alvaro Herrera | 2023-02-07 10:55:57 | Re: [PATCH] Compression dictionaries for JSONB |