| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | Ayush Vatsa <ayushvatsa1810(at)gmail(dot)com> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Proposal to include --exclude-extension Flag in pg_dump |
| Date: | 2024-03-19 11:19:25 |
| Message-ID: | CAEZATCWQapOjs7dHj0g8v1U8qk4vN-FRKLGDpt3TY7zeNLLHtw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, 16 Mar 2024 at 17:36, Ayush Vatsa <ayushvatsa1810(at)gmail(dot)com> wrote:
>
> Attached is the complete patch with all the required code changes.
> Looking forward to your review and feedback.
>
This looks good to me. I tested it and everything worked as expected.
I ran it through pgindent to fix some whitespace issues and added
another test for the filter option, based on the test case you added.
I'm marking this ready-for-commit (which I'll probably do myself in a
day or two, unless anyone else claims it first).
Regards,
Dean
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Add-support-for-exclude-extension-in-pg_dump.patch | text/x-patch | 12.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shlok Kyal | 2024-03-19 11:26:10 | Re: speed up a logical replica setup |
| Previous Message | Peter Eisentraut | 2024-03-19 11:02:45 | Re: SQL:2011 application time |