| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Petr Korobeinikov <pkorobeinikov(at)gmail(dot)com>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, Jeevan Chalke <jeevan(dot)chalke(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: psql :: support for \ev viewname and \sv viewname |
| Date: | 2016-05-06 12:30:31 |
| Message-ID: | CAEZATCW9EAv2X0iVaVRuUWRs4KjA=Pm+pdni99_p1dS-kqmEnA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 4 May 2016 at 13:23, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 5/4/16 3:21 AM, Dean Rasheed wrote:
>> Well, appendStringLiteralAH() takes both, so that sets a precedent.
> Works for me. Could you supply an updated patch with a static function
> instead of a macro? Then I think this is good to go.
>
> (bonus points for some tests)
>
OK, pushed that way.
I didn't get round to adding any tests though. I strikes me that the
most likely bugs in this area are bugs of omission, like this and the
missing PARALLEL SAFE recently fixed for functions. Ideally tests
would be able to spot those kinds of issues, but it's not obvious how
to write such tests.
Regards,
Dean
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2016-05-06 13:03:31 | Re: old_snapshot_threshold's interaction with hash index |
| Previous Message | Peter Eisentraut | 2016-05-06 12:21:55 | Re: Feature request: make cluster_name GUC useful for psql prompts |