| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, wrb <wrb(at)autistici(dot)org>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #13863: Select from views gives wrong results |
| Date: | 2016-02-08 09:41:10 |
| Message-ID: | CAEZATCW6FFD4Bkdx91KztiEoUvwyykmVL5KgOV-O1jaQroAzOQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 7 February 2016 at 23:21, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> wrote:
> I think for now the following patch is best. This preserves the ability
> to push degenerate HAVING clauses through an explicit GROUP BY () as
> well as an implicit one, but prevents pushdown in all other cases.
>
> Includes comment and regression test.
>
Yes, I think that's probably the best solution for now. Longer term I
think it might be possible to do better, along the lines discussed
above, but I haven't had time to explore any of those options.
Note that with this change to the "if" condition, the next "else if"
condition can be simplified back to just:
else if (parse->groupClause)
{
/* move it to WHERE */
...
Andres, are you going to take this one?
Regards,
Dean
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-02-08 09:44:34 | Re: BUG #13863: Select from views gives wrong results |
| Previous Message | Andres Freund | 2016-02-08 09:18:52 | Re: Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby |