| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improving RLS qual pushdown |
| Date: | 2015-04-28 06:57:01 |
| Message-ID: | CAEZATCW4TiCojhNHC0Q4bZ4LNFbhSQWdvCmf0KMMk=8=hFpfFw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 27 April 2015 at 17:33, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> Dean,
>
> * Dean Rasheed (dean(dot)a(dot)rasheed(at)gmail(dot)com) wrote:
>> I took another look at this and came up with some alternate comment
>> rewording. I also added a couple of additional comments that should
>> hopefully clarify the code a bit.
>
> Finally got back to this. Made a few additional changes that made
> things look clearer, to me at least, and added documentation and
> comments. Also added a bit to the regression tests (in particular, an
> explicit check on the RLS side of this, not that it should be different,
> but just in case things diverge in the future). Please review and let
> me know if you see any issues.
>
Thanks, that all looks very good.
Regards,
Dean
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-04-28 10:38:45 | Re: INSERT ... ON CONFLICT UPDATE/IGNORE 4.0, parser/executor stuff |
| Previous Message | Peter Geoghegan | 2015-04-28 06:49:39 | Re: INSERT ... ON CONFLICT UPDATE/IGNORE 4.0 |