| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, David Rowley <dgrowleyml(at)gmail(dot)com> |
| Subject: | Re: Numeric multiplication overflow errors |
| Date: | 2021-07-05 09:44:11 |
| Message-ID: | CAEZATCVz9DG7mDfGP66G4hkWKUjwW-W0VMyuMLB99fPsSubDxg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 2 Jul 2021 at 19:48, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
>
> If you allow me a small suggestion.
> Move the initializations of the variable tmp_var to after check if the function can run.
> Saves some cycles, when not running.
>
OK, thanks. I agree, on grounds of neatness and consistency with
nearby code, so I've done it that way.
Note, however, that it won't make any difference to performance in the
way that you're suggesting -- elog() in Postgres is used for "should
never happen, unless there's a software bug" errors, rather than, say,
"might happen for certain invalid inputs" errors, so init_var() should
always be called in these functions.
Regards,
Dean
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-07-05 09:46:19 | Re: Skipping logical replication transactions on subscriber side |
| Previous Message | Yugo NAGATA | 2021-07-05 09:11:51 | Re: [HACKERS] WIP aPatch: Pgbench Serialization and deadlock errors |