| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add error functions: erf() and erfc() |
| Date: | 2023-03-08 23:29:12 |
| Message-ID: | CAEZATCVfLNaq=hoJ=qKN5_swUMzKvTrjTXdDYaRz1GezHn=8Dg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 8 Mar 2023 at 20:11, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> On Mon, Feb 27, 2023 at 12:54:35PM +0000, Dean Rasheed wrote:
> > + /*
> > + * For erf, we don't need an errno check because it never overflows.
> > + */
>
> > + /*
> > + * For erfc, we don't need an errno check because it never overflows.
> > + */
>
> The man pages for these seem to indicate that underflow can occur. Do we
> need to check for that?
>
No, I don't think so. The docs indicate that if an underflow occurs,
the correct result (after rounding) should be returned, so I think we
should just return that result (as we do for tanh(), for example).
Regards,
Dean
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2023-03-08 23:39:08 | Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump) |
| Previous Message | Thomas Munro | 2023-03-08 23:24:05 | Re: Add error functions: erf() and erfc() |