| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, Joseph Koshakow <koshy44(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Infinite Interval |
| Date: | 2023-09-22 08:09:12 |
| Message-ID: | CAEZATCVav7ahQajVzURPSLXBTezA9hT_s+3Kv3L32Z=Yfu8j3A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 22 Sept 2023 at 08:49, Ashutosh Bapat
<ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
>
> Following code in ExecInterpExpr makes it clear that the
> deserialization function is be executed in per tuple memory context.
> Whereas the aggregate's context is different from this context and may
> lives longer that the context in which deserialization is expected to
> happen.
>
Right. I was about to reply, saying much the same thing, but it's
always better when you see it for yourself.
> Hence I have changed interval_avg_deserialize() in 0007 to use
> CurrentMemoryContext instead of aggcontext.
+1. And consistency with other deserialisation functions is good.
> Rest of the patches are
> same as previous set.
>
OK, I'll take a look.
Regards,
Dean
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Erik Rijkers | 2023-09-22 08:12:38 | Re: Row pattern recognition |
| Previous Message | Ashutosh Bapat | 2023-09-22 07:48:51 | Re: Infinite Interval |