| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, luajk(at)qq(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | Re: BUG #18103: bugs of concurrent merge into when use different join plan |
| Date: | 2023-09-27 07:29:27 |
| Message-ID: | CAEZATCVGWykA48zdMNziD=u0cipioYKTKy_+7S_UBxM828kYAg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Tue, 26 Sept 2023 at 10:46, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
>
> Agreed. We need rowmarks for MERGE too. I found that the following
> comment from plannodes.h is very useful in understanding this.
>
> * When doing UPDATE, DELETE, or SELECT FOR UPDATE/SHARE, we have to uniquely
> * identify all the source rows, not only those from the target relations, so
> * that we can perform EvalPlanQual rechecking at need.
>
Ah, good. Thanks. That confirms my understanding.
> To nitpick, there are some comments that may need to be updated to
> include MERGE, such as the comments for ExecRowMark, RowMarkType and
> PlanRowMark.
>
Agreed. I'll see about doing that.
Regards,
Dean
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Laurenz Albe | 2023-09-27 08:04:24 | Re: md5 password valid and invalid after upgrading |
| Previous Message | Kyle MacMillan | 2023-09-26 23:14:06 | md5 password valid and invalid after upgrading |