| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | songjinzhou <tsinghualucky912(at)foxmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, japinli <japinli(at)hotmail(dot)com> |
| Subject: | Re: Added prosupport function for estimating numeric generate_series rows |
| Date: | 2024-11-29 13:10:14 |
| Message-ID: | CAEZATCUh=tDahTBAGLRsYu_4NJ4W1MiAdy3g8U54nTc3VvjSGQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 29 Nov 2024, 12:01 David Rowley, <dgrowleyml(at)gmail(dot)com> wrote:
> On Fri, 29 Nov 2024 at 18:50, songjinzhou <tsinghualucky912(at)foxmail(dot)com>
> wrote:
> > Hello, thank you and David Rowley for your comments.
> >
> > I have used pgindent to adjust the code format and added comments and
> missing regression test cases. Here is the patch of version v3.
>
> It looks fine to me. The only things I'd adjust are stylistic,
> namely; 1) remove two tabs before the goto label, 2) remove redundant
> braces around the goto cleanup, 3) rename the variable "q" to
> something slightly more meaningful, maybe "res" or "rows".
>
> I'll defer to Dean.
>
>
There are a couple more things that I think need tidying up. I'll post an
update when I get back to my computer.
Regards,
Dean
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marcos Pegoraro | 2024-11-29 13:13:30 | Re: Use or not record count on examples |
| Previous Message | Shlok Kyal | 2024-11-29 13:07:42 | Re: Disallow UPDATE/DELETE on table with unpublished generated column as REPLICA IDENTITY |