| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Does rewriteTargetListIU still need to add UPDATE tlist entries? |
| Date: | 2021-04-26 14:27:59 |
| Message-ID: | CAEZATCUY4FWFnxdLPZnCJmqfLpLcbKRePj9SrDueqe5J_tso7Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 26 Apr 2021 at 15:09, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Thanks for looking at that. On reflection I think this must be so,
> because those rewriter mechanisms were designed long before we had
> trigger-updatable views, and rewriteTargetListIU has never added
> tlist items like this for any other sort of view. So the ability
> to insert the original view output column has necessarily been there
> from the beginning. This is just getting rid of a weird implementation
> difference between trigger-updatable views and other views.
>
FWIW, I had a look at this too and came to much the same conclusion,
so I think this is a safe change that makes the code a little neater
and more efficient.
Regards,
Dean
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2021-04-26 14:36:29 | Re: Enhanced error message to include hint messages for redundant options error |
| Previous Message | Justin Pryzby | 2021-04-26 14:24:34 | Re: tab-complete for ALTER TABLE .. DETACH PARTITION CONCURRENTLY |