Re: Numeric multiplication overflow errors

From: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Numeric multiplication overflow errors
Date: 2021-07-01 10:02:51
Message-ID: CAEZATCUS5sJ7BAPLE6m=GaqisZoxY92+p2ZOjkrbJbtewzuwOw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 1 Jul 2021 at 10:27, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
>
> I'll post an update in a while. Thanks for the review.
>

One other thing I'm wondering about is back-patching. I was originally
thinking of these as back-patchable bug fixes, but changing the binary
format of the aggregate serialization states feels dodgy for a
back-patch.

But then, these functions are only callable in an aggregate context,
and work in pairs. It could be a problem if someone were using them to
pass state between different servers, but I see no evidence of them
being used in that way.

For reference, this will affect the following:
- int8_avg_serialize()
- numeric_avg_serialize()
- numeric_poly_serialize()
- numeric_serialize()

and the corresponding *_deserialize functions.

Regards,
Dean

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2021-07-01 10:22:45 Re: [PATCH] pgbench: add multiconnect option
Previous Message Kyotaro Horiguchi 2021-07-01 09:45:25 ECPG doesn't compile CREATE AS EXECUTE properly.