From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | Vik Fearing <vik(at)postgresfriends(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: MERGE ... WHEN NOT MATCHED BY SOURCE |
Date: | 2023-03-21 12:24:31 |
Message-ID: | CAEZATCUR39xOOj5kj6nq4+Jj4N=q0bydHKaj_=aN0ACKpaiatA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, 21 Mar 2023 at 10:28, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> > + /* Combine it with the action's WHEN condition */
> > + if (action->qual == NULL)
> > + action->qual = (Node *) ntest;
> > + else
> > + action->qual =
> > + (Node *) makeBoolExpr(AND_EXPR,
> > + list_make2(ntest, action->qual),
> > + -1);
>
> Hmm, I think ->qual is already in implicit-and form, so do you really
> need to makeBoolExpr, or would it be sufficient to append this new
> condition to the list?
>
No, this has come directly from transformWhereClause() in the parser,
so it's an expression tree, not a list. Transforming to implicit-and
form doesn't happen until later.
Looking at it with fresh eyes though, I realise that I could have just written
action->qual = make_and_qual((Node *) ntest, action->qual);
which is equivalent, but more concise.
Regards,
Dean
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2023-03-21 12:26:27 | Re: MERGE ... WHEN NOT MATCHED BY SOURCE |
Previous Message | Önder Kalacı | 2023-03-21 12:02:58 | Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL |