From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
---|---|
To: | Brendan Jurd <direvus(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: 9.3: Empty arrays returned by array_remove() |
Date: | 2013-05-31 07:55:49 |
Message-ID: | CAEZATCUOkyz=VszVRVWCWLvJdxRTjKgODMhj-GqX1yEaQNQ7ew@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 31 May 2013 08:34, Brendan Jurd <direvus(at)gmail(dot)com> wrote:
> On 31 May 2013 02:52, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
>> Testing 9.3beta, it seems that array_remove() may return an empty 1-d
>> array whose upper bound is lower than its lower bound. I know that we
>> discussed allowing this kind of array, but I don't think that
>> discussion reached any conclusion, other than to agree that the
>> current empty 0-d array behaviour would be kept in 9.3.
>>
>
> That's right, zero-D is still the only supported representation of an
> empty array, so when array_remove() yields an empty array it ought to
> be zero-D. Good catch.
>
Yeah, that's what I thought. Here's a patch to fix it, plus a new
regression test to confirm that the result is a zero-D array.
Regards,
Dean
Attachment | Content-Type | Size |
---|---|---|
array_remove.patch | application/octet-stream | 1.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2013-05-31 11:12:03 | Re: Freezing without write I/O |
Previous Message | Fabien COELHO | 2013-05-31 07:41:09 | Re: [PATCH] add --throttle to pgbench (submission 3) |