From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Add pg_size_bytes() to parse human-readable size strings. |
Date: | 2016-02-20 10:48:04 |
Message-ID: | CAEZATCU7M5C72--o07jz4Z3q6gQhOfL6wbWjbBwJvzD12DckSg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On 20 February 2016 at 10:33, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
> On Sat, Feb 20, 2016 at 7:17 PM, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
>> On 20 February 2016 at 10:12, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
>>> Happy first commit.
>>
>> Arg. Not so much.
>>
>> Looks like I broke something -- looking into it now :-(
>
> The terabyte conversion is at fault:
> Expected:
> ! -1tb | -1099511627776
> Result:
> ! -1tb | -1
>
> + else if (pg_strcasecmp(strptr, "gb") == 0)
> + multiplier = 1024 * 1024 * 1024;
> + else if (pg_strcasecmp(strptr, "tb") == 0)
> + multiplier = 1024 * 1024 * 1024 * 1024L;
> Why adding an 'L' here?
Ah, looks like it needs to be 'LL' because it needs to be a 64-bit literal.
Regards,
Dean
From | Date | Subject | |
---|---|---|---|
Next Message | Dean Rasheed | 2016-02-20 11:11:43 | pgsql: Fix pg_size_bytes() to be more portable. |
Previous Message | Michael Paquier | 2016-02-20 10:33:00 | Re: pgsql: Add pg_size_bytes() to parse human-readable size strings. |