| From: | Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com> |
|---|---|
| To: | "anarazel(at)anarazel(dot)de" <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Boszormenyi Zoltan <zb(at)cybertec(dot)at>, Andres Freund <andres(at)2ndquadrant(dot)com>, Greg Stark <stark(at)mit(dot)edu>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: overlapping strncpy/memcpy errors via valgrind |
| Date: | 2013-02-17 19:31:44 |
| Message-ID: | CAEYLb_VixOdHdZ6kBL_1AZJaGFvSBPeq4p24WNhPfzmuY__cNw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 17 February 2013 18:52, anarazel(at)anarazel(dot)de <andres(at)anarazel(dot)de> wrote:
> You already need a suppression file to use valgrind sensibly, its easy enough to add it there. Perhaps we should add one to the tree?
Perhaps you should take the time to submit a proper Valgrind patch
first. The current approach of applying the patch that Noah Misch
originally wrote (but did not publicly submit, iirc) on an ad-hoc
basis isn't great. That is what you've done here, right?
--
Regards,
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | anarazel@anarazel.de | 2013-02-17 19:39:59 | Re: overlapping strncpy/memcpy errors via valgrind |
| Previous Message | anarazel@anarazel.de | 2013-02-17 18:52:46 | Re: overlapping strncpy/memcpy errors via valgrind |