From: | Peter Geoghegan <peter(at)2ndquadrant(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Setting -Werror in CFLAGS |
Date: | 2012-01-04 19:04:52 |
Message-ID: | CAEYLb_UM_DH0zXPo_mHSzJND49EeUqYFPZvesxRgkgrJ5hiy0A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 4 January 2012 18:44, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Tue, Jan 3, 2012 at 9:23 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I'm also less than thrilled with the idea that whatever the gcc boys
>> decide to make a warning tomorrow will automatically become a MUST FIX
>> NOW for us.
>
> I'm not thrilled about that either. Especially since they seem to be
> adding more and more warnings that are harder and harder to work
> around for issues that are less and less important. Unimportant
> warnings that are easily avoidable are not so bad, but...
I'd have a certain amount of sympathy for that view. It took building
with Clang to notice that we incorrectly used one enum rvalue to
assign to a variable of another enum type, which I thought was a
little bit surprising; I'd have expected GCC to catch that one, since
it is pretty likely to be valid.
--
Peter Geoghegan http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training and Services
From | Date | Subject | |
---|---|---|---|
Next Message | Jim Nasby | 2012-01-04 19:06:23 | Re: Page Checksums + Double Writes |
Previous Message | Robert Haas | 2012-01-04 18:44:07 | Re: Setting -Werror in CFLAGS |