| From: | Marc Dean <marc(dot)dean(dot)jr(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Sergei Kornilov <sk(at)zsrv(dot)org>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, "michael(dot)paul(dot)powers(at)gmail(dot)com" <michael(dot)paul(dot)powers(at)gmail(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #15293: Stored Procedure Triggered by Logical Replication is Unable to use Notification Events |
| Date: | 2018-07-24 17:43:30 |
| Message-ID: | CAEU75wAdO7_t6MzSqWxua4Cca+KKpuHYYz6txz=VgETX--yYvw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
If Sergei is correct, I would volunteer to work on the patch. I am
completely new to the codebase but this issue affects me. According to the
documentation for `ProcessCompletedNotifies()` it should be called just
before going idle... so perhaps in src/backend/replication/logical/worker.c
at the tail end of `apply_handle_commit`? Again.. just looking at the
codebase today so if this is beyond beginner level I will assist w/ testing
instead.
On Tue, Jul 24, 2018 at 11:58 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> Hi,
>
> On 2018-07-24 16:19:45 +0300, Sergei Kornilov wrote:
> > I checked this bug and found reason: we do not notify backends about new
> events by call ProcessCompletedNotifies from logical worker.
> > New notify from regular backend does call ProcessCompletedNotifies: send
> signal to all listen backends and found new events for youself.
> > But i am not sure where is correct place for call
> ProcessCompletedNotifies in logical worker src/backend/replication/logical/worker.c
> and i can not provide patch.
>
> Peter, Petr, this is the second report of this issue. Anything?
>
> Greetings,
>
> Andres Freund
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sergei Kornilov | 2018-07-24 18:22:18 | Re: BUG #15293: Stored Procedure Triggered by Logical Replication is Unable to use Notification Events |
| Previous Message | Andres Freund | 2018-07-24 15:58:29 | Re: BUG #15293: Stored Procedure Triggered by Logical Replication is Unable to use Notification Events |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sergei Kornilov | 2018-07-24 18:22:18 | Re: BUG #15293: Stored Procedure Triggered by Logical Replication is Unable to use Notification Events |
| Previous Message | Bossart, Nathan | 2018-07-24 17:21:25 | Re: Add SKIP LOCKED to VACUUM and ANALYZE |