| From: | Mike Blackwell <maiku41(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | [PATCH] Clear up perlcritic 'missing return' warning |
| Date: | 2018-05-22 01:07:03 |
| Message-ID: | CAESHdJpfFm_9wQnQ3koY3c91FoRQsO-fh02za9R3OEMndOn84A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
This is the first in a series of patches to reduce the number of warnings
from perlcritic. The current plan is to submit a separate patch for each
warning or small set of related warnings, to make reviewing more
straightforward.
This particular patch addresses the warning caused by falling off the end
of a subroutine rather than explicitly returning. It also contains
additions to the perlcritic configuration file to ignore a couple of
warnings that seem acceptable, bringing it in line with the buildfarm's
configuration for those warnings.
Thanks to Andrew for assistance getting my environment set up.
Mike Blackwell
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-add-returns-to-Perl-files-where-missing.patch | text/x-patch | 38.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-05-22 01:08:23 | Re: Postgres, fsync, and OSs (specifically linux) |
| Previous Message | Euler Taveira | 2018-05-22 00:13:12 | Re: Add --include-table-data-where option to pg_dump, to export only a subset of table data |