| From: | robins <tharakan(at)gmail(dot)com> |
|---|---|
| To: | Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add some regression tests for SEQUENCE |
| Date: | 2013-03-13 10:11:53 |
| Message-ID: | CAEP4nAzKSHZ0S73jZK3Tam5pvjAo5GYgc1BK4Y5s8t3VhLP-oA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks Laurenz.
Would correct these (and readup) before submitting next patch.
--
Robins
Tharakan
On 13 March 2013 13:49, Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at> wrote:
> robins wrote:
> > Attached is a small patch to test corner cases related to Sequences
> (basically aimed at increasing
> > code-coverage of sequence.sql in regression tests).
> >
> > Look forward to any and all feedback.
>
> Looks ok except that the patch is backwards
> (all added lines start with "-"). I found a typo:
> "exit" instead of "exist".
>
> You should add the patch to the next commitfest
> (http://wiki.postgresql.org/wiki/Submitting_a_Patch)
>
> Yours,
> Laurenz Albe
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2013-03-13 11:50:54 | Re: Request for vote to move forward with recovery.conf overhaul |
| Previous Message | Boszormenyi Zoltan | 2013-03-13 09:31:53 | Re: Re: Proposal for Allow postgresql.conf values to be changed via SQL [review] |