| From: | Robins Tharakan <tharakan(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18828: Crash when pg_get_logical_snapshot_meta() passed empty string |
| Date: | 2025-03-06 07:20:59 |
| Message-ID: | CAEP4nAxvLVzvkt+ABBfd_yDhBJjhJnKqDXZorLf=VG-Yp23TmA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, 6 Mar 2025 at 17:13, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> On Tue, Mar 4, 2025 at 10:44 PM Bertrand Drouvot
> <bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
> >
> > After sleeping on it, PFA a simplified version.
>
Running tests on v5 patch for a few hours was uneventful (which is good).
> I think we don't need to even do palloc() for the buffer as we can use
> the char[MAXPGPATH] instead. I've attached the patch to improve the
> parse_snapshot_filename() function and add some regression tests.
> Please review these changes.
>
I've updated that with this patch too. Will update if something comes up.
-
robins
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2025-03-06 08:11:36 | Re: BUG #18828: Crash when pg_get_logical_snapshot_meta() passed empty string |
| Previous Message | Masahiko Sawada | 2025-03-06 06:42:35 | Re: BUG #18828: Crash when pg_get_logical_snapshot_meta() passed empty string |