From: | Robins Tharakan <tharakan(at)gmail(dot)com> |
---|---|
To: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Re: Add regression tests for COLLATE |
Date: | 2013-05-10 01:27:35 |
Message-ID: | CAEP4nAwXU=5cWCXxXTTftBTS-672qGf=9_8LR1nxd8MU26EskA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
One workaround is to use DROP COLLATION IF EXISTS, that conveys the message
without UTF8 in the message string.
But three other tests use ALTER COLLATION and I see no way but to comment /
disable them. Currently have them disabled (with comments as to what they
do, and why they're disabled).
This updated patch doesn't have UTF8 string anywhere.
Let me know if you prefer to remove the commented out tests completely.
--
Robins Tharakan
On 9 May 2013 07:44, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robins Tharakan <tharakan(at)gmail(dot)com> writes:
> > Fabien pointed out that currently does not check for non-trivial
> locales. I
> > am still on the learning curve about LOCALEs and so, let me know if this
> is
> > a show-stopper. I guess I could look at it and get back in some time with
> > more tests as Fabien points out.
>
> You really can't, because there is no guarantee that any given machine
> will have anything except "C" and "POSIX". But there's another problem:
> I believe this test will fail on any machine where the database is
> created with an encoding different from UTF8, because that encoding is
> named in some of the error messages in the expected output.
>
> This stuff is not easy to test in a portable way.
>
> regards, tom lane
>
Attachment | Content-Type | Size |
---|---|---|
regress_collate_v3.patch | application/octet-stream | 7.7 KB |
unknown_filename | text/plain | 158 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2013-05-10 01:47:46 | Re: improving PL/Python builds on OS X |
Previous Message | Evan D. Hoffman | 2013-05-10 01:22:55 | Re: Re: [GENERAL] pg_upgrade fails, "mismatch of relation OID" - 9.1.9 to 9.2.4 |