Re: SQL Property Graph Queries (SQL/PGQ)

On Mon, Feb 10, 2025 at 11:00 PM Junwang Zhao <zhjwpku(at)gmail(dot)com> wrote:
>
> Hi Ashutosh,
>
> On Mon, Feb 10, 2025 at 2:14 PM Ashutosh Bapat
> <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
> >
> > On Thu, Feb 6, 2025 at 8:22 PM Junwang Zhao <zhjwpku(at)gmail(dot)com> wrote:
> > > > >
> > > >
> > > > I see you have added some negative tests - object not found tests, but
> > > > I didn't see positive tests. Hence I haven't added those changes in
> > > > the attached patchset. But we certainly need those changes. You may
> > > > want to submit a patch with positive tests. That code needs to be
> > > > fixed before committing anyway.
> > >
> > > The attached file adds the positive tests.
> >
> > Hi Junwang,
> > Thanks for the patch, but please post it as a separate patch in the
> > full patch-set, otherwise CFBot gets confused.
>
> Ok, see the attached.
>
> 0001-0009 are the original patches of 20250127 with rebase of master
> 0010 fix ci error due to `Show more-intuitive titles for psql
> commands`, see a14707da564e
> 0011 fix ci error due to unstable collation tests, we should not
> depend on pg_catalog."default", I observed 002_pg_upgrade.pl failure
> caused by this.
> 0012 trivial refactor of property graph object address
>
> >
> > --
> > Best Wishes,
> > Ashutosh Bapat
>
>
>
> --
> Regards
> Junwang Zhao

Here is v11 with another trivial refactor, I add a seperate patch file 0013, in
insert_property_record, there is no need to check `type`, `typmode` and
`collation` if the property doesn't exists before, in AlterPropGraph, there is
no need to call `check_all_labels_properties` for each added vertex or edge.

Other files remain unchanged except I’ve added some missing document and
typo fix we discussed in the list but not included in the previous
patch, I included
them in 0008.

--
Regards
Junwang Zhao