Re: Memory leak fix in psql

From: Junwang Zhao <zhjwpku(at)gmail(dot)com>
To: "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Japin Li <japinli(at)hotmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Memory leak fix in psql
Date: 2022-07-20 08:03:02
Message-ID: CAEG8a3Jj6h+Csi4+3rtqmH_Cor8jvfE+Ypw7OWZ6302R=AJazw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thanks for your explanation, this time I know how it works, thanks ;)

On Wed, Jul 20, 2022 at 3:04 PM tanghy(dot)fnst(at)fujitsu(dot)com
<tanghy(dot)fnst(at)fujitsu(dot)com> wrote:
>
> > On Wed, Jul 20, 2022 at 12:51:24PM +0800, Junwang Zhao wrote:
> > > Though the patch looks good, I myself think the patch should be edited
> > > and submitted by Tang
> > > It's easy to attach a fixed patch based on the comments of the thread,
> > > but coins should be
> > > given to Tang since he is the first one to find the mem leak.
>
> Hello, Zhao
>
> Thanks for your check at this patch.
>
> I appreciate your kindly comment but there may be a misunderstanding here.
> As Michael explained, committers in Postgres will review carefully and
> help to improve contributors' patches. When the patch is finally committed
> by one committer, from what I can see, he or she will try to make sure the
> credit goes with everyone who contributed to the committed patch(such as
> bug reporter, patch author, tester, reviewer etc.).
>
> Also, developers and reviewers will try to help improving our proposed patch
> by rebasing it or adding an on-top patch(like Japin Li did in v2).
> These will make the patch better and to be committed ASAP.
>
> Good to see you at Postgres community.
>
> Regards,
> Tang

--
Regards
Junwang Zhao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2022-07-20 08:05:47 Re: Memory leak fix in psql
Previous Message Masahiko Sawada 2022-07-20 07:57:35 Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns