From: | Junwang Zhao <zhjwpku(at)gmail(dot)com> |
---|---|
To: | Robert Treat <rob(at)xzilla(dot)net> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Erikjan Rijkers <er(at)xs4all(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: [doc] fix a potential grammer mistake |
Date: | 2022-08-03 22:44:09 |
Message-ID: | CAEG8a3JgNFR8fQZLCo3LKQP1CuYAnRDxgX5yPVcVwUkUSHjGFA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Aug 4, 2022 at 12:42 AM Robert Treat <rob(at)xzilla(dot)net> wrote:
>
> On Wed, Aug 3, 2022 at 11:15 AM Junwang Zhao <zhjwpku(at)gmail(dot)com> wrote:
> >
> > Attachment is a corrected version based on Tom's suggestion.
> >
> > Thanks.
> >
> > On Wed, Aug 3, 2022 at 9:56 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > >
> > > Erikjan Rijkers <er(at)xs4all(dot)nl> writes:
> > > > I don't think these "were"s are wrong but arguably changing them to
> > > > "have" helps non-native speakers (like myself), as it doesn't change the
> > > > meaning significantly as far as I can see.
> > >
> > > I think it does --- it changes the meaning from passive to active.
> > > I don't necessarily object to rewriting these sentences more broadly,
> > > but I don't think "have issued" is the correct phrasing.
> > >
> > > Possibly "The user issued ..." would work.
> > >
>
> Is there a reason that the first case says "just" issued vs the other
> two cases? It seems to me that it should be removed.
Attachment is a patch with the "just" removed.
Thanks
>
> Robert Treat
> https://xzilla.net
--
Regards
Junwang Zhao
Attachment | Content-Type | Size |
---|---|---|
0001-doc-rewrite-some-comments-to-make-them-more-precise.patch | application/octet-stream | 1.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Jonathan S. Katz | 2022-08-03 22:55:05 | Re: pg15b2: large objects lost on upgrade |
Previous Message | Matthias van de Meent | 2022-08-03 22:35:13 | Re: postgres_fdw: batch inserts vs. before row triggers |