Re: Should fix a comment referring to stats collector?

From: Junwang Zhao <zhjwpku(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Should fix a comment referring to stats collector?
Date: 2024-12-28 07:25:46
Message-ID: CAEG8a3JbMCHna=N5ZSx6huLnTDfW34kw7Pf2n8+3M-9UrrwesA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 31, 2023 at 11:02 PM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>
> On Mon, Aug 1, 2022 at 09:05:45PM +0900, torikoshia wrote:
> > On 2022-07-30 02:53, Alvaro Herrera wrote:
> >
> > > I don't think this refers to the statistics collector process; I
> > > understand it to refer to ANALYZE that captures the data being stored.
> >
> > Thanks for the explanation!
> >
> > > Maybe it should just say "K may be chosen at ANALYZE time".
> >
> > It seems clearer than current one.
>
> Change made in master.

I believe some redundant wording has been committed.

K may be chosen may be chosen at ANALYZE time.

Attached patch fixes it and with some line adjustments.

>
> --
> Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
> EDB https://enterprisedb.com
>
> Only you can decide what is important to you.
>
>

--
Regards
Junwang Zhao

Attachment Content-Type Size
v1-0001-remove-redundant-wording-in-pg_statistic.h.patch application/octet-stream 1.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2024-12-28 10:28:40 Re: pg_attribute_noreturn(), MSVC, C11
Previous Message Tatsuo Ishii 2024-12-28 05:45:46 Re: Proposal: add new API to stringinfo