| From: | Junwang Zhao <zhjwpku(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | Re: [PATCH v1] eliminate duplicate code in table.c |
| Date: | 2022-07-22 08:06:50 |
| Message-ID: | CAEG8a3J=o8d1mrv4UBjicYMNn9ve4Y3crRkC=XxQJHcvFUkcUA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Here is the patch v7. Thanks!
On Fri, Jul 22, 2022 at 1:15 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Fri, Jul 22, 2022 at 7:39 AM Kyotaro Horiguchi
> <horikyota(dot)ntt(at)gmail(dot)com> wrote:
> >
> > + errmsg("cannot operate on relation \"%s\"",
> >
> > Other callers of errdetail_relkind_not_supported() describing
> > operations concretely. In that sense we I think should say "cannot
> > open relation \"%s\"" here.
> >
>
> Sounds reasonable to me. This will give more precise information to the user.
>
> --
> With Regards,
> Amit Kapila.
--
Regards
Junwang Zhao
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Eliminate-duplicate-code-in-table.c.patch | application/octet-stream | 4.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2022-07-22 08:14:00 | Re: Fast COPY FROM based on batch insert |
| Previous Message | Etsuro Fujita | 2022-07-22 08:03:19 | Re: postgres_fdw: Fix bug in checking of return value of PQsendQuery(). |