Re: [PATCH] Add a inline function to eliminate duplicate code

From: Junwang Zhao <zhjwpku(at)gmail(dot)com>
To: mahendrakar s <mahendrakarforpg(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Add a inline function to eliminate duplicate code
Date: 2022-08-05 07:56:14
Message-ID: CAEG8a3+j_FyCVg7Op0pjW4Gvca9fODE-rHOpDJdEDtp-J=y+Lw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Any more reviews?

On Tue, Aug 2, 2022 at 9:24 PM mahendrakar s <mahendrakarforpg(at)gmail(dot)com> wrote:
>
> Patch is looking good to me.
>
> Thanks,
> Mahendrakar.
>
> On Tue, 2 Aug 2022 at 16:57, Junwang Zhao <zhjwpku(at)gmail(dot)com> wrote:
>>
>> abstract the logic of `scankey change attribute num to index col
>> number` to change_sk_attno_to_index_column_num, which is a static
>> inline function.
>>
>> --
>> Regards
>> Junwang Zhao

--
Regards
Junwang Zhao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2022-08-05 08:22:38 Re: Patch to address creation of PgStat* contexts with null parent context
Previous Message Dilip Kumar 2022-08-05 07:25:30 Re: making relfilenodes 56 bits