| From: | Junwang Zhao <zhjwpku(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: [dsm] comment typo |
| Date: | 2023-08-21 10:15:36 |
| Message-ID: | CAEG8a3+Oq-k2p0jLoiYwh=Km254RL8R-sZWKekahwssQrJB2rw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 21, 2023 at 5:16 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 18 Aug 2023, at 11:10, Junwang Zhao <zhjwpku(at)gmail(dot)com> wrote:
> >
> > In the following sentence, I believe either 'the' or 'a' should be kept, not
> > both. I here keep the 'the', but feel free to change.
>
> > * handle: The handle of an existing object, or for DSM_OP_CREATE, the
> > - * a new handle the caller wants created.
> > + * new handle the caller wants created.
>
> Since the handle doesn't exist for DSM_OP_CREATE, both "a handle" and "the
> handle" seems a tad misleading, how about "the identifier for the new handle the
> caller wants created"?
>
Sounds great 👍
> --
> Daniel Gustafsson
>
--
Regards
Junwang Zhao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2023-08-21 10:18:04 | Re: Adding a LogicalRepWorker type field |
| Previous Message | Zhijie Hou (Fujitsu) | 2023-08-21 10:12:03 | RE: [PoC] pg_upgrade: allow to upgrade publisher node |